Re: Buffer overflow in "lpr"

Todd Vierling (tv@POBOX.COM)
Wed, 09 Jul 1997 11:46:16 -0400

On Wed, 9 Jul 1997, Todd Vierling wrote:

: Try this on for size: strlcat(), a limited strcat() that limits on total
: buffer size rather than source argument size. I found this idea somewhere
: in a book long forgotten, but here's a diff for lib/libc/string/strncat.c
: that implements it.

Doh! For some reason the original message appeared in my NetBSD sorted
mailbox. Lemme post the entire source of strlcat.c.

: Usage:
:
: char *strlcat(char *dst, const char *src, size_t n);
:
: Concatenate src on the end of dst. At most n+1 bytes are written at dst (at
: most n+1-strlen(dst) bytes being appended). If n<=strlen(dst), does
: nothing. Returns dst.

=====

/*-
* Copyright (c) 1990 The Regents of the University of California.
* All rights reserved.
*
* This code is derived from software contributed to Berkeley by
* Chris Torek.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
* are met:
* 1. Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* 3. All advertising materials mentioning features or use of this software
* must display the following acknowledgement:
* This product includes software developed by the University of
* California, Berkeley and its contributors.
* 4. Neither the name of the University nor the names of its contributors
* may be used to endorse or promote products derived from this software
* without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
/* Adapted from strncat.c by Todd Vierling; Berkeley license above applies. */

#if defined(LIBC_SCCS) && !defined(lint)
/*static char *sccsid = "from: @(#)strncat.c 5.6 (Berkeley) 1/26/91";*/
static char *rcsid = "$Id$";
#endif /* LIBC_SCCS and not lint */

#include <string.h>

/*
* Concatenate src on the end of dst. At most n+1 bytes are written at dst
* (at most n+1-strlen(dst) bytes being appended). If n<=strlen(dst),
* does nothing. Returns dst.
*/
char *
strlcat(dst, src, n)
char *dst;
const char *src;
register size_t n;
{
register char *d = dst;

while (*d != 0) {
d++;
n--;
}
if (n > 0) {
register const char *s = src;

do {
if ((*d = *s++) == 0)
break;
d++;
} while (--n != 0);
*d = 0;
}
return (dst);
}

=====
== Todd Vierling (Personal tv@pobox.com; Business tv@iag.net) Foo-bar-baz! ==
== System administrator/technician, Internet Access Group, Orlando Florida ==
== Dialups in Orange, Volusia, Lake, Osceola counties - http://www.iag.net ==